Daniel Compton
Daniel Compton
@JJN2 if `lein-kibit run` is successful and prints no suggestions then it should exit 0. Or do you mean that it ran successfully and printed out suggestions?
What is the purpose of running kibit via Maven? Do you want a non-zero exit code somewhere in the chain further up? How do you signal to Maven that Kibit...
This might be a better rule for Eastwood than Kibit also?
Happy to take a PR mentioning this in the README
Hey, I'd probably prefer to see the whole change for #175 in one PR, rather than changing all the rules partway through. This is a good start for that though.
> Ah I see, so you mean enumerating all the rules in one go? Sorry, I mean I'd rather see one patch set for #175, rather than changing the defrules...
Hey, what I'm saying is, I don't want to merge a partial PR towards #175, when you provide a PR, provide all of it in one patch, i.e. the changes...
It’s certainly possible, and I’d be happy to take a patch for it. Boot users can just call kibit with the src and test paths at the CLI with lein,...
Hey thanks for posting these issues. I don't have any time to work on them at the moment, but would happily accept patches for the issues you've highlighted.
Yep, I've thought this would be a handy feature to have for lots of different purposes. Happy to see a PR for this.