kibit icon indicating copy to clipboard operation
kibit copied to clipboard

(vec (map ...)) => (mapv ...)

Open pbudzik opened this issue 10 years ago • 3 comments
trafficstars

(into [](map ....) or (vec (map ...) => (mapv ...)

pbudzik avatar Jan 12 '15 19:01 pbudzik

Hi @pbudzik, thanks for this. I'll look at it more closely when I'm back from break. In the meantime, can you add some tests for this suggestion? Thanks!

danielcompton avatar Jan 12 '15 19:01 danielcompton

Done.

pbudzik avatar Jan 12 '15 19:01 pbudzik

I'm a little conflicted on this, #83 already has raised that into [] isn't always equivalent to vec, specifically in the case where you're using reducers. If you wanted to split this PR out into two parts then I'd be happy to merge the (vec (map part, and leave the into [] part until we have a way to add metadata on rules to warn people about this.

Relates to #107

danielcompton avatar Apr 20 '15 02:04 danielcompton