Christian Weiss

Results 88 comments of Christian Weiss

> If any tracer ever will need the concept of activated, then the hook needs to exist as in theory you should be able to implement any tracer via these...

> @ndrwrbgs Side question - why is it of such interest for this property the OnActivated? Even if I ignore that event, the thing I cannot catch here is the...

I think this should work. It obviously only implements some interface methods though. ```csharp public class EventHookSpan : ISpan { private readonly ISpan span; private readonly EventHookTracer tracer; internal EventHookSpan(ISpan...

What's the status here? Is an update still required / useful at this point? I would have time in the next weeks to do a few minor things.

Status update: Java-like examples are coming with #70 - this will probably be merged by the end of the week. For the "instrumentation" side, I just released a first version...

fyi: @saschaholesch is working on the C# version of https://github.com/yurishkuro/opentracing-tutorial - you can find it here: https://github.com/saschaholesch/opentracing-tutorial/tree/csharp

Thx for the PR. Could you please explain in more detail why the builtin `AsyncLocalScopeManager` (that uses `AsyncLocal`/`ThreadLocal`) doesn't work for your scenario? Using `ThreadStatic` seems problematic as it doesn't...

I still do not really understand the usability of this because: * A single `ITracer` instance can only have a single `IScopeManager` and typically, there's only one `ITracer` per application....

I know who you are. You are doing great OSS work and I really appreciate discussing this with you. Any new topic is an opportunity for me to learn something...

A note on the code itself: I think it would be better to call this "ThreadStaticScopeManager" as `ThreadStatic` is what it uses under the hood. `ThreadLocal` is a separate C#...