Christian Weiss

Results 88 comments of Christian Weiss

Hi! If you can get the SOAP action from the outgoing HttpRequestMessage, you can use the `OnRequest`-property on `ConfigureHttpHandler()` to set an action that inspects the outgoing HTTP calls and...

As described by @bobcat1506 in #85, the SOAP standard has a header named "[SOAPAction](https://www.w3.org/TR/2000/NOTE-SOAP-20000508/#_Toc478383528)". I don't think this should be added to this library right now as it can easily...

Hmm. We had to change the examples/testbed code anyway because of async/await so maybe our code is closer to being actual "examples" than in Java?! I'm ok with both so...

@carlosalberto @MikeGoldsmith how do you want to proceed with this?

I wonder if this should actually be a change or just an additional method. It's quite common in .NET to have both variants (e.g. `int.Parse` vs `int.TryParse`). The difference in...

Out of curiosity (I'm still pretty new to this), what's your use cases where having `TryGetBaggageItem` would simplify code? Is it "if this baggage item doesn't exist, set it"? If...

I understand. But it's not really a good idea to add baggage with a `null`/`default` value as that's transferred via the wire and therefore unnecessary overhead. There might even be...

Well, but here it gets complicated because we can't reliably dictate tracer behavior so we can't reliably say whether or not the tracer stores `null` values. So if you only...

I think we have to come to an agreement about whether or not tracers are allowed to ignore keys with `null`-values. I've just asked a question about this in https://gitter.im/opentracing/public...

There has only been one response regarding Jaeger - it does NOT store keys with null values. So if we would change this API, the following call would return `false`,...