Christian Weiss

Results 88 comments of Christian Weiss

This was mentioned in yesterday's OTSC call and according to that, all projects should use the Apache license. Is this already final? Can I just change the license in opentracing-csharp...

Here's the PR for the license change in opentracing-csharp: https://github.com/opentracing/opentracing-csharp/pull/65

Could/should the scope of this be extended to all types of L7 appliances - e.g. L7 load balancers, reverse proxies etc? They might be on separate machines or controlled by...

Do you have a use case for why having them in the same assembly is problematic? These classes are very simple and don't add any dependencies to the main library....

I'd prefer some more opinions from other people before you create a PR (and invest your time). I understand your reasoning from a theoretical software architecture point of view, but...

fyi, we've already briefly discussed this in https://github.com/opentracing/opentracing-csharp/issues/55#issuecomment-363588253 back in February.

The .NET framework will get built-in support for distributed tracing with an OpenTracing-like API. They have some important differences though. One of them is that they changed the meaning of...

I have mixed feelings about this. It's important to stick to the spec but it's also important to not break stuff for "trivial" reasons - especially on the instrumentation/app side....

As you wrap an inner type, I think it shouldn't be necessary for you to know about this. You would just call `_innerScope.Dispose()` and that would call `_span.Finish()` if `finishSpanOnDispose`...

A general question regarding your project: I understand the value of having hooks for "OnSpanStarted" & "OnSpanFinished" but what's the value of having a "OnSpanActivated" hook? As that's an internal...