opentracing-csharp icon indicating copy to clipboard operation
opentracing-csharp copied to clipboard

Rename examples to testbed.

Open carlosalberto opened this issue 7 years ago • 4 comments
trafficstars

Renamed examples to testbed, along the namespace name, to align to https://github.com/opentracing/opentracing-java/issues/185

carlosalberto avatar Apr 06 '18 00:04 carlosalberto

Was this really necessary? I understand the need to get the core API to match the Java implementation as close as possible but I think this is superfluous, with Examples being a more accurate description of what is there.

MikeGoldsmith avatar Apr 09 '18 09:04 MikeGoldsmith

@MikeGoldsmith It was mentioned in the past (in the Java repo) that the examples name was confusing as some of the scenarios are kinda exotic, and also because the purpose of these so-called examples was more to test out the API (along with changes and experimental features), more than being actual examples (and thus, confusing for newcomers).

Other repos do have actual examples, so we may want to add a few of them ;)

carlosalberto avatar Apr 09 '18 15:04 carlosalberto

Hmm. We had to change the examples/testbed code anyway because of async/await so maybe our code is closer to being actual "examples" than in Java?!

I'm ok with both so feel free to merge/not merge as you like!

cwe1ss avatar Apr 26 '18 09:04 cwe1ss

@carlosalberto @MikeGoldsmith how do you want to proceed with this?

cwe1ss avatar May 14 '18 19:05 cwe1ss