Miguel Camba
Miguel Camba
Interesting, thanks for reporting. Are you able to create a failing test for the bug? If so I think I can merge a fix next week.
I admit I didn't eve see this issue until now because I was attending my child birth precisely that day. @dogindot Is this still an issue. I believe I can...
@iwilliams sorry for not taking care of this yet. Can you rebase over master? I'm pretty sure tests will be green after that.
I'll pull the PR and investigate if there's a less breaking way of achieving the same thing, but I agree with the idea. I want this to be part of...
I'm somewhat confused. The component uses DDAU everywhere. Nothing relies on bindings propagating up. And you can define a search function that doesn't return anything and updates the options. So,...
you can: ```hbs {{repo.full_name}} ``` and ```js searchRepo() { searchRepo(term) { doSomethingAsync().then((newOptions) => this.set('theOptions', newOptions))l // never return anything } } ``` I generally do not advice this because now...
@pjcarly do you have any idea of what the fix would be? I also fail to see why this would have changed in 3.0. The logic is mostly a 1:1...
@steveszc sorry for delaying this so much, but finally I was able to find time to move CI to github actions and fix it. Can you rebase, this time it...
@steveszc ping
That would be unreasonably complex. Those classes are there and users are free to ignore them, but having default classes is somewhat required for the 99% of usages.