ember-power-select icon indicating copy to clipboard operation
ember-power-select copied to clipboard

Published 20 hours ago • verified publisher icon cibernox

Add missing @highlightOnHover attribute to power-select-multiple

Open iwilliams opened this issue 5 years ago • 2 comments
trafficstars

power-select-multiple.hbs is not passing through the @highlightOnHover attribute.

iwilliams avatar Jun 10 '20 22:06 iwilliams

@iwilliams sorry for not taking care of this yet. Can you rebase over master? I'm pretty sure tests will be green after that.

cibernox avatar Jun 29 '20 21:06 cibernox

@cibernox Sorry I don't really know what's going on here, I originally opened this PR using the github UI since it was just a simple one liner. I also don't usually contribute patches upstream so I'm not not sure what's going on with my rebase. Here's what I did just now:

  1. git checkout master in my forked repo
  2. git remote add upstream [email protected]:cibernox/ember-power-select.git
  3. git fetch upstream
  4. git merge upstream/master
  5. git checkout patch-1
  6. git rebase upstream/master
  7. git push -f (It was complaining about my remote history :thinking:)

Looks like I'm still getting the :x:

iwilliams avatar Jun 29 '20 22:06 iwilliams

closed by #1687

mkszepp avatar Feb 10 '24 06:02 mkszepp