Miguel Camba

Results 297 comments of Miguel Camba
trafficstars

Hey, thanks for reporting! I'm not sure how to fix it. Perhaps check how much it has move and if it's a very small amount (a couple pixels) still consider...

This looks good, I only wonder if there is a test you can add to ensure we never regress on this. Other than that looks good.

I'm fairly sure that is pretty outdated, but lately I'm extremely shot of time to update it. For starters, I'd use ember-animated instead of ember-fire now. I'll see if I...

Are you on the latest version? I'm aware of a couple a11y things that can me improved, but that one in particular I think that was fixed here: https://github.com/cibernox/ember-basic-dropdown/pull/224

@drallieiv can you check the version of ember-basic-dropdown?

Added proper labels. I won't have time next week as I'll be travelling

@ctcpip I won't have time this week to look at this, but have good A11Y is on my roadmap. Ping me back at the end of the next week so...

I was overly optimistic with the amount of work a moving involves. I'm still assembling Ikea stuff. Can we delay it until mid-next week?

@BitBrit I'm happy to help, but aria is not my area of expertise. I'd take any PR that help with this. I am particularly worried about the first error, what...

I missed this when it was originally reported. If it does work with 3.21 I can only assume it's a bug in Ember or Ember-data itself? Also, if worked before...