Miguel Camba
Miguel Camba
@lazybensch can you rebase this? The code looks good now, and the tests should be green if you rebase.
Oops, that's a shame. Probably yes, we should test animations, even if that involves adding custom waiters or something.
thanks! I'll take a look
@kstinson14 I'm not sure about this: > If I were to return false in onkeydown, the default browser focus behavior would also be prevented AFAIK, returning `false` from `onkeydown` does...
Can you provide a simple reproduction. I believe that this scenario is covered by the tests, seems weird that we had a regression on that. Perhaps you have conflicting versions...
Hey, this has been open for way too long. I'll try to allocate some time on Thursday for going though the changes and check how VoiceOver behaves.
Yeah, we had to give up that feature when updating to glimmer components. You still can do it by overriding the `optionsComponent`, but it's very inconvenient. I hope that named...
If you only pass `class` right now, doesn't that give you a single div already?
Sorry, I forgot about this. Checking
I have an alternative solution that I think it's more aligned with the future in which components are tagless by default, and it's not a breaking change today. The problem...