ember-power-select
ember-power-select copied to clipboard
cibernox
Explicitly test animation handling
We've just had to perform a scrambled production rollback after hitting https://github.com/cibernox/ember-power-select/issues/1338.
@williamweckl raises a good point in that issue about errors shipping to production silently...
no error in the test because animationEnabled is false for test environment
shouldn't be enabled in tests too? This error was silently deployed in production even with a high test coverage 😢
Seeing as ember-basic-dropdown will disable animation in tests unless an explicit override is passed in, would it make sense to add some tests in this addon that run with animation enabled to prevent similar problems happening in the future?
Oops, that's a shame. Probably yes, we should test animations, even if that involves adding custom waiters or something.
