Christoph John

Results 221 comments of Christoph John
trafficstars

Hi @david-gibbs-ig , I want to take a look at this in the near future. What do you think about building the FIXLatest classes and dictionary in an external module...

Sounds like a sensible enhancement. Are you able to provide a PR? Thanks

Thanks for the PR. I've authorized Coverall for this repo.

@the-thing , link should work now. Had to add it manually on Coveralls.

@the-thing :+1: for `quickfix.converter` package. The change should be OK for 3.0.0 milestone. However, we probably need to decouple this from the Coveralls change.

Sorry for the long delay, still busy with other stuff. :-( Will hopefully be able to get back to this soon...

@the-thing I see that you did this change for Travis. Would it be much work to integrate this into the Java CI jobs?

Hi @david-gibbs-ig , thanks for extracting this smaller PR. Just a question: the code generation runs with the build and generates the dictionaries from the Orchestra file instead of from...

I could use a few more eyes on this. Any comments from other regular committers? @philipwhiuk @the-thing maybe? Personally I think it is a step in the right direction especially...

Just my 2 cents: did you try to set the schema as property of your JDBC driver? This could then be part of the URL you pass to the JDBC...