Christoph John
Christoph John
You misread my comment. :) The statement you quoted does refer to the status quo in QFJ where you can only specify the encoding per JVM.
Did not follow this up through the changed code yet but there are NullPointerExceptions at at quickfix.DataDictionary.checkHasValue(DataDictionary.java:683) at quickfix.DataDictionary.iterate(DataDictionary.java:555) at quickfix.DataDictionary.validate(DataDictionary.java:538) at quickfix.Session.next(Session.java:998) Probably forgotten to pass the default validation...
Hi @philipwhiuk , I wanted to add a test for QFJ-981 which is related to this issue. However, I do not seem to be able to push changes to this...
Got a 'permission denied'. Maybe got one of the parameters wrong. Will try again later.
Nevermind, turned out I was using the wrong branch
> I'm wondering whether it's better to rename the new struct to `ValidationSettings`. It's kind of a half way between `SessionSettings` and `DataDictionarySettings`. Sounds sensible. `ValidationSettings` is more descriptive.
Hi @philipwhiuk , I was thinking about into which version this fix needs to go. When using semantic versioning (which I'm roughly trying to follow) this needs to go into...
I think I failed at trying to resolve the merge conflict. Will check.
I think there might be a case for adding this. I am just asking myself if it always will behave as you want. What tells you that the next unknown...
``` Error: Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.991 s