Christoph John
Christoph John
Hi @philipwhiuk , good catch. Got any suggestions? ;)
Hi guys, thanks for your comments so far. I don't think we should go back to the `java.util.Date` API and use `Date` or `SimpleDateFormat` (not threadsafe). There still might be...
Hi @leonchen83 > but leap second with mills and nanos need further consideration Could you please elaborate on this or add what still needs to be done to #456 as...
Hmm, probably the `verify()` method call needs to be moved further up in `nextLogon()` but this needs to be tested carefully. Are you able to provide a unit test?
Thanks for the report. Are you by any chance able to provide a unit test for this problem?
Could you please take a look at the tests in `SessionTest` and create a test based on that? It should be possible to reconstruct the problem with that. E.g. here...
I think this could be a false positive. The check for the MessageProcessor threads is rather dumb since it simply checks for the occurrence of a String in a stack...
Maybe the existing test's check can be improved to correctly determine the thread status.
BTW, to add to my former comments, you could use `ProtocolFactory.SOCKET` in the test to see if the problem goes away. However, since the problem is not reproducible every time...
> BTW, to add to my former comments, you could use `ProtocolFactory.SOCKET` in the test to see if the problem goes away. Changed on master via #475