Chris Havlin

Results 143 comments of Chris Havlin
trafficstars

note on current state: no new tests, a new example in the documentation would be good.

edit: added tests and updated docs. Going to switch to ready-to-review. I won't be around for a little while but feel free to review!

Don't think I can help resolve the open questions but I will say the updated docs read nicely! Except for the `pr_backport.py` bit, which I was confused by until I...

Good question! I'll need to refresh the tests but I think my main hang up was whether there are more frontends that should be switched to the `transaction` handler that...

Ok, I'll work on adding the `transaction` to the base class and I'll get the tests passing then open it up for review!

Latest commit takes care of the remaining suggestions, I also caught some missing abstract method implementations that I initially missed because we don't have tests for the http and sdf...

@neutrinoceros no worries! it's also not critical... and actually might benefit from holding off for a bit. I've been refactoring the dask work off of main and I think it'll...

Didn't actually answer your question -- we do **not** need this for 4.1

Ok! Ya, that makes sense to me. But I do think we should change the example in the docs. Could use a different dataset to demo the `linthresh=auto` functionality or...

(for posterity -- found and resolved the open threads)