Chris Havlin

Results 150 comments of Chris Havlin
trafficstars

Thanks for starting this discussion @munkm ! I'm in favor of broadening the scope of PRs that require just 1 vote, particularly any infrastructure/maintenance PRs. I also agree with Matt...

I think it's that pyright still considers those imports private, I think we'd need to change all the `from X import A` imports to `from X import A as A`...

If adding `__all__` to `loaders.py` is sufficient and doesn't just end up exposing more pyright failures then I think it's worth it. We also don't test with pyright, so we're...

I'd also find this hugely helpful.... but don't think I have the time right now to work on it in earnest. And for what it's worth, I've spent some time...

> a cutting plane through a sphere, given a normal vector, is the same as an equatorial slice through a sphere where the sphere has been rotated such that its...

Note that the test for the 4d interpolator is kinda slow cause it uses quite a big array, (`random_data = np.random.random((64, 64, 64, 64))`). I'm inclined to drop that down...

Will check if it's slower than the 3d case, but 4d with (64,64,64,64) took maybe 4-6 seconds if I remember correctly

@matthewturk so the 3D and 4D scale at the same rate with the total array size: ![lin_interp_scaling](https://github.com/yt-project/yt/assets/22038879/56a10a82-a769-4e5b-90dd-544609c5d662) code here https://gist.github.com/chrishavlin/9370e2a4a1895745a40c46f39d6c44f4 The full test time (`pytest --durations=10 yt/utilities/tests/test_interpolators.py`): ``` 3.20s call...

oh, one more push coming... i'm going to go through all the other tests and add make the booleans explicit in the interpolator calls.