Chris Havlin

Results 150 comments of Chris Havlin
trafficstars

Thanks for the detailed thoughts, @neutrinoceros ! And searching back through issues and PRs, I see now that there's been a lot of related discussion and attempts circling around this...

+1 from me for removing parenthesis. also agree it'd be nice to merge ASAP if folks agree with the change.

just FYI, i hit the button for the tests to run, but you'll likely get unrelated failures after your merge with main (e.g., #4785 ).

I like this idea! I initially thought it'd be cool to implement this by adding a `data_source` kwarg to `annotate_quiver` -- you could then use a cut_region to apply the...

note: thanks to @y-samuel-lu for raising the issue on slack!

Thanks for the suggestions! I need to look back at where my PR stalled... > One issue I do want to point out involves periodic datasets. If I remember right,...

No insight into why you're getting different results between the on-axis projection and the off-axis when aligned with the axis, but here's an example that results in very different behavior....

I didn't mention it in my review, but while reviewing i did actually run some more comparison tests between old and new methods with a couple datasets and some different...

+1 for expanding `set_norm` functionality! I think that's a nice compromise that leaves a clear way forward for future development.

> Hmm, this doesn't look like my error, but maybe it is? Did I miss marking something as C++? @matthewturk not your error, that's the flaky build error that happens...