Christian Schlotter
Christian Schlotter
I did a small POC implementation which would fullfill both needs: https://github.com/kubernetes/kube-state-metrics/compare/master...chrischdi:poc-additional-metric-types?expand=1 Of course this would need more considerations and note that this is only a "dirty hack implementation": *...
cc @mrueg follow up for the short slack discussion we had 😊
@mrueg or others, what would be best to continue on this issue? Seen from a configuration perspective I have two kind of versions in my head: 1. The chaotic one...
I updated the POC to work with feedback from @bavarianbidi (thx) and changed the config layout a little bit. Note: code is not really cleaned up but works for the...
I would also suggest to just not add the label in this case :-) #1777 would implement that behaviour.
Fixed via #1777, xref: https://github.com/kubernetes/kube-state-metrics/pull/1777/files#diff-1cbeb50a6b171ac66f4fad40018421010ed1733ea97fcb40b65a7ebd5e7e3d77R424 /close
Example config: ```yaml kind: CustomResourceStateMetrics spec: resources: - groupVersionKind: group: cluster.x-k8s.io kind: Cluster version: v1beta1 namespace: capi subsystem: cluster labelsFromPath: name: [metadata, name] namespace: [metadata, namespace] uid: [metadata, uid] metrics:...
A thing to note: This PR as of now would currently add a breaking change to the experimental feature configuration file for the custom resources. If wanted we could also...
> Thanks for this contribution, I like the change and I think it takes CRD generation in the right direction. > > One thing I did not understand is where...
> I see, that maybe should not have gotten through. We should use `apiVersion` instead to be consistent with the kubernetes API. Since this feature is experimental, we should be...