Christian Schlotter
Christian Schlotter
Relevant for discussing if to delay or not: https://github.com/golangci/golangci-lint/issues/2997#issuecomment-1190681977 List of disabled linters: > * `var-declaration` (_default_): https://revive.run/r#var-declaration > * `errorf` (_default_): https://revive.run/r#errorf > * `unexported-return` (_default_): https://revive.run/r#unexported-return > *...
`Release specific issues:` / `Adjust KCP to migrate registry` should be fixed now :-)
Just because I did some research: some context when considering an implementation of `clusterctl alpha rollout undo` for KCP: if it gets implemented it should take care to not allow...
I think `map[string]interface` won't even work / break with kubebuilder and generating the deepcopy stuff. If we change it to a typed struct, e.g.: ```go type PortOpts struct { ......
@mkjpryor could you please explain how you are triggering the deletion? The cluster-api book recommends deleting all resources via the `cluster` object: https://cluster-api.sigs.k8s.io/user/quick-start.html#clean-up to "ensure a proper cleanup of your...
I think thats a great cleanup and nicely doable using the conversion prior to a release with v1beta1 :+1:
Maybe worth to note that kube-state-metrics now supports custom resource definitions: https://github.com/kubernetes/kube-state-metrics/pull/1710 Although it does not yet work for `_info` metrics: https://github.com/kubernetes/kube-state-metrics/issues/1755
Would be a great thing to have and at the Cluster API project would be interested in it too - xref: https://github.com/kubernetes-sigs/cluster-api/issues/7158 I was about to ask the question in...
/lgtm from my side. But requires a maintainer for approval (which I am not).
Addition: the same thing happens when importing `sigs.k8s.io/cluster-api/api/v1alpha4` (sorry, I did write `cluster-api-provider-openstack` here first but mixed up the repos).