Christian Schlotter

I'll take a look and try to at least implement the improvement mentioned by @vincepri here: https://github.com/kubernetes-sigs/cluster-api/issues/3982#issuecomment-946793975 😃

I agree for #6040 regarding this issue. #4321 and #6614 are more related to #7010

> Q: Should the validation only consider the spec.version or should it also consider the current status? > > E.g. if we only validate the spec it's possible to bump...

I think we cannot just remove setting the condition because, as Vince mentioned, the two codepaths are mutual exclusive. https://github.com/kubernetes-sigs/cluster-api/blob/7f879be68d15737e335b6cb39d380d1d163e06e6/controllers/cluster_controller.go#L477-L482 Will get executed when not using a ControlPlane provider https://github.com/kubernetes-sigs/cluster-api/blob/bfc6f80add5c21b8dc2b704951f42bc14708ebc4/controllers/cluster_controller_phases.go#L238-L247...

Propable duplicate of #4321 and #6614 ?

I assume this is still valid to get implemented to also proceed at #5218 (which was triaged as accepted and this one is required). @enxebre are you still working on...

/assign

One question: Does making use of `RolloutAfter` limit the functionality for RolloutAfter. E.g. a user may have already set `RolloutAfter` to a timestamp in the future (e.g. to enforce recreation...

Could you try to checkout/move the repository to `/home/pvala/go/src/sigs.k8s.io/cluster-api` instead of `/home/pvala/go/src/github.com/kubernetes-sigs/cluster-api`? Maybe this fixes the generate 🤔

We need a version which includes https://github.com/kubernetes-sigs/cluster-api/issues/6350#issuecomment-1141383233 /hold