slackathon icon indicating copy to clipboard operation
slackathon copied to clipboard

Refactor the dispatcher job to use Active Job's `rescue_from` API

Open chancancode opened this issue 8 years ago • 0 comments

We can refactor this rescue block to use Active Job's rescue_from API.

The main motivation for this (making the code more idiomatic is a nice bonus) is to avoid the automatic retry behavior in Sidekiq. It is not usually useful (and very confusing) to retry the commands. According to this it seems like handling errors manually will stop Sidekiq from retrying automatically, as long as we don't call retry_job.

chancancode avatar Nov 21 '17 21:11 chancancode