opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

refactor(sdk-node): fix eslint warning

Open chancancode opened this issue 9 months ago • 2 comments
trafficstars

Which problem is this PR solving?

Fixes the following eslint warnings from the sdk-node package:

/home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/opentelemetry-sdk-node/src/index.ts
  20:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax
  21:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax
  22:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax
  23:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax
  24:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax
  25:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax
  26:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax
  27:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax

Ref #5365

Short description of the changes

This feels a bit different than the other ones (#5399), as this is a meta- package, and these are wildcard exports to re-export all the public exports from the upstream packages into individual namespaces.

There is no risk of accidentally exporting something that wasn't meant to be public, and it would be a huge pain to enumerate things from each of the upstream packages and keep things in-sync.

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] eslint

Checklist:

  • [x] Followed the style guidelines of this project
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

chancancode avatar Jan 30 '25 02:01 chancancode