Bartlomiej Plotka

Results 755 comments of Bartlomiej Plotka

Makes sense, thanks for raising. I think this screams for config object instead of flag though 🤔

Hello from the Bug Bash! Just to sent the update, we attempted this and we learned a lot, but it's still todo. NOTE: For further work, we might consider other...

Thanks for this finding. I think both you and https://github.com/prometheus/client_golang/pull/1143 was right. I think you would agree that before https://github.com/prometheus/client_golang/pull/1143 we had broken implementation as both signature and comments of...

Fix for this was reverted: https://github.com/prometheus/client_golang/releases/tag/v1.20.5, so reopening. We plan to deliver long term fix in https://github.com/prometheus/client_golang/issues/1639

Please help! Ideally we setup dependabot too for those (:

Sounds this work was paused. That's ok, we learned so much! We also removed other half finished CI jobs to avoid confusion. Thanks for all the work! We can get...

/prombench cancel It's up for long time, cancelling to save credits (you can inspect the data in retrospective). Hope that's ok!

> I'm just not sure about performance though, appending samples is a hot path, right? Would it create too much overhead by possibly increasing two new counters? No, it shouldn't...

@amanycodes did you use GenAI for your questions? They feel a bit unrelated (e.g. Go interfaces, initialization or counter performance), but it's hard to tell. Even if you understand those...

Happens heavily on main https://github.com/prometheus/prometheus/actions/runs/12272224646/job/34240557245 `TestProviderStaleTargetsAreDropped`