Bartlomiej Plotka
Bartlomiej Plotka
@dependabot reopen
Thanks! Amazing -- do you mind rebasing and fixing DCO (signing commit)?
Fixed by https://github.com/prometheus/client_golang/pull/1183
I realized we already kind of agreed to supporting this... https://github.com/prometheus/client_golang/issues/684 so probably too late to challenge it cc @beorn7 @ArthurSens - do you remember what's the benefit other than...
I believe https://github.com/prometheus/test-infra/issues/688#issuecomment-2365227765 closed it.
uuu sweet, let us know when it's rdy for review
Hi, thanks for reporting! This is intentional as there is no global interval setting for rule evaluations (aka global.evaluation_interval), because that option only exists in Prometheus. In GMP it's a...
Got it, thanks. I assume you can point people directly to the Prometheus docs, but you have to mention the nuance to specify that one field explicitly, right? The point...
Thanks. Moving this to prioritization queue (OSS help wanted too). ### Acceptance Criteria * Add omitempty with 1m default https://github.com/GoogleCloudPlatform/prometheus-engine/blob/2c7b2fd2c9e27648efc6d1024dfcbaca73709bfb/pkg/operator/apis/monitoring/v1/rules_types.go#L118
Yes, it confuses everyone, it's because Prometheus does not follow proper Go Module semver ... which is difficult to follow in retrospective due to https://www.reddit.com/r/golang/comments/ipwea6/go_modules_have_a_v2_problem/ 🙈