Bartlomiej Plotka

icon indicating a website link https://bwplotka.dev/

icon company Google icon location London, UK icon location Fascinated by challenging engineering problems & distributed systems. Go & OSS fan. Prometheus maintainer, Thanos co-author. CNCF TAG Observability Tech Lead.

Results 706 comments of Bartlomiej Plotka

ignore deallocated VMs during azure discovery

Hello from the Bug Scrub! As @roidelapluie mentioned https://github.com/prometheus/prometheus/pull/5569#issuecomment-1766254833 we updated an SDK, so this code needs to be fully recreated, so perhaps let's close this PR? Sounds like this...

Fix: scrape docker targets with empty network list

(During Prometheus bug scrub meeting) @shachakz friendly ping to put this behind the configuration flag. Otherwise let us know if you don't have time to pursue this.

Implement scrape-time rule evaluation

@SuperQ the documentation is in this PR: https://github.com/prometheus/prometheus/blob/bd4a6a7e8d1cef2f99a9f22cdce77bb1d0d50339/docs/configuration/configuration.md#scrape_rule_configs, but true, it might be amazing to show end user example of this in the PR description.

Added Service Discovery for OCI Compute.

(During Prometheus bug scrub meeting) Sounds like no activity since July. Thanks anyway, let's close it for now. You can always reopen @mayurOciSA 💪🏽

Poor documentation around grpc client side logging.

Note that your example is using v1 (but this issue is still applicable for v2)

Poor documentation around grpc client side logging.

Also, see code reference to find correct argument types: https://pkg.go.dev/github.com/grpc-ecosystem/go-grpc-middleware/[email protected]/interceptors/logging#WithDecider Tests are also great resource if you are still lost: https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v2/interceptors/logging/interceptors_test.go#L506

Poor documentation around grpc client side logging.

Closing for now, unless you still need help and more examples.

Need help thinking through and event-publishing pattern with middleware

Closing for now, unless you still need help - we can reopen. Thanks!

[validator] Let me customize the error code

This is pretty old and we know have `v2` code with different structure. Let us know if this is still important, we can reopen.

[grpc_retry] Broken retry logic on client streaming

Do you mind trying [v2 retry](https://github.com/grpc-ecosystem/go-grpc-middleware/tree/v2/interceptors/retry) and potentially writing unit test to reproduce? That would be super helpful. The data you provides is too little. We don't know where this...