Bartlomiej Plotka

Results 708 comments of Bartlomiej Plotka

Closing, unless you want to continue on this, we can then reopen.

I think you could try using our `v2` interceptor with reporter interface https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v2/interceptors/reporter.go#L90, let us know if this work!

Sounds like this is solved, feel free to visit our Slack channel or we can reopen this issue, thanks!

Great point. I am then considering closing this issue as it's doable with selector and skip... Question is, is this interface nice and if not, can we improve it before...

Actually you just mentioned improvements ideas... 1. Auth is great, but we need selection for many other interceptors so skip/selector works better. 2. Selector looks nice, it's bit explicit but...

Still, not sure if I like the selector types (match, not) etc. It gets pretty complex pretty soon and requires a lot of maintenance. I think I would stick to...

done in https://github.com/grpc-ecosystem/go-grpc-middleware/pull/543

Seems not relevant, given tracing is no longer part of this repo (in `v2`), given OpenTelemetry maintains great interceptor.

Let us know if this still needed - it's quite an old issue (: Also see v2 if you want to contribute this.

So it would be relatively easily in v2 to extend authFunc to include callMeta. However for streaming calls, this wouldn't be that trivial. Let us know if this is still...