Ben Lesh

Results 230 comments of Ben Lesh

Okay, the interesting thing from the RxJS side would be that we could make any RxJS `Subject` a valid `CancelSignal` with the addition of a `signaled` property. Sorta cool. Similarly,...

> Would you mind explaining how that would look like and be used on subjects? Basically, CancelSignal and Subject are both multicast Observables. But now that I think about it,...

> Previous CancellationToken Proposal: .register did call the callback immediately if the signal was already cancelled This is what RxJS Subscriptions do. If this proposal has async cancellations callbacks, i...

this should be: `import { NEVER } from `rxjs'`` and then usage is just: `NEVER` (not `never()` or `NEVER()`)

FYI: I think version is *very* important, especially going forward.

> I think on each operator doc page we should just link to the corresponding RxJS operator doc page. This sounds fine to me. I guess I'm not sure what...

I've tried this locally and I didn't have an issue. Do you have a minimal file that reproduces the issue?

Maybe `toObservable`, but otherwise, yeah. It's really early here so maybe I'm just tired, but looking at the code in question I'm not entirely sure what was wrong with it....

@calebboyd: I made that issue you referenced. :) and it's whole-heartedly related to my question here. It seems to me that _subscription_ should occur asynchronously by default, while event emission...

NOTE: Will do a follow up to remove `animationFrameProvider.schedule`, since it's not public and we're not using it after this PR.