Ben Lesh

Results 230 comments of Ben Lesh

After talking with @leggechr, I think so many people are using `observers` that we can only deprecate it for now. The use cases seem to mostly be around `if (subject.observers.length...

You'll need to run `npm run api_guardian:update` and commit the new golden files to fix the CI errors.

@jennings So sorry this is such a late response. I don't have a way to force the checks to rerun without getting into your branch and pushing up an empty...

The added test may be a *little* slow. 1 ms per tick would have still done it. But it's fine, I guess.

@cartant on `QueueAction` `requestAsyncId` returning `1`. It was actually returning `void` before, now that I look at it. However, that's not a valid `TimerHandle` and the (obviously crazy) API is...

Haven't reviewed yet, but I know the bug. It IS a bug, but the fix is also a breaking change. So we need to punt until next major.

This one is just one we missed. I don't like the late deprecation, but I somehow doubt the operator version of this is in wide use.

> can you show a use case for observing cancellation synchronously from the outside? The above case is an example. But more to the point would be something like a...