Ben Ashbaugh
Ben Ashbaugh
Discussed in the April 16th teleconference. We'll give this one more week for review, but are hoping to merge shortly.
Merging as discussed in the May 21st teleconference.
See also: https://github.com/KhronosGroup/OpenCL-CTS/pull/1917#issuecomment-1995430013
FYI, I'm seeing failures here too, looking into them now.
This PR needs a new owner, so for now I've removed "focused review" and added "help wanted".
I spoke too soon, and I'm seeing a few failures in double to half conversions, for non-round-to-even rounding modes: Example for: test_conversions half_rtn_double -w -1 ``` Building convert_half_rtn( double )...
I think we should merge this as-is and fix any bugs that appear. @lakshmih can you run a "wimpy" test first to gain confidence that the changes are OK? Maybe...
I just created an `fp16-staging` branch, as we discussed. If this PR is retargeted at this branch I will merge it, also as we discussed. It's been a few days...
Removing "focused review", since we are reviewing and merging changes into the staging branch now.
Check that the state transition back to "completion" is tested, from the diagram in the spec: https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#_add_new_section_section_5_x_1_command_buffer_lifecycle