OpenCL-CTS icon indicating copy to clipboard operation
OpenCL-CTS copied to clipboard

test allocations: restore small number of work items in case of reduction

Open gwawiork opened this issue 1 year ago • 5 comments

gwawiork avatar Mar 27 '24 10:03 gwawiork

@kpet This is related to https://github.com/KhronosGroup/OpenCL-CTS/pull/1852 We use reduction argument on simulation then too high number of work items makes test very long and we see timeouts. Would be nice have previous value set. I agree there is a need to implement function which will calculate this number accordingly

gwawiork avatar Mar 27 '24 10:03 gwawiork

Merging this PR would result in failures for the implementations listed in #1852. Is the issue you're seeing on a final device or development environment? If the latter, maybe we could introduce command line options to help.

kpet avatar Mar 27 '24 10:03 kpet

Merging this PR would result in failures for the implementations listed in #1852. Is the issue you're seeing on a final device or development environment? If the latter, maybe we could introduce command line options to help.

By default value is set as in #1852 Only when someone use reduction argument (percentage in command line) Do you use it ? if (g_reduction_percentage != 100)

gwawiork avatar Mar 27 '24 15:03 gwawiork

@gwawiork Apologies I'd missed that when quickly skimming through it. I've now approved the PR. Should be fine.

kpet avatar Mar 27 '24 18:03 kpet

Discussed in the April 16th teleconference. We'll give this one more week for review, but are hoping to merge shortly.

bashbaug avatar Apr 19 '24 21:04 bashbaug

Merging as discussed in the May 21st teleconference.

bashbaug avatar May 21 '24 15:05 bashbaug