OpenCL-CTS icon indicating copy to clipboard operation
OpenCL-CTS copied to clipboard

cl_khr_command_buffer::info_state does not check the state after the command buffer has completed execution

Open kpet opened this issue 2 years ago • 3 comments

Once a command buffer completes execution (assuming no other pending instances), its state should be transitioned back to CL_COMMAND_BUFFER_STATE_EXECUTABLE_KHR. The info_state test should check that.

kpet avatar Mar 31 '23 12:03 kpet

Check that the state transition back to "completion" is tested, from the diagram in the spec:

https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#_add_new_section_section_5_x_1_command_buffer_lifecycle

bashbaug avatar May 16 '23 15:05 bashbaug

There is already state verification for RunStateInfoTests():

error = verify_state(CL_COMMAND_BUFFER_STATE_EXECUTABLE_KHR);
test_error(error, "verify_state failed");

Could you please specify the details of the requirements for the tests? What other tests should be extended here?

pj87 avatar May 22 '23 14:05 pj87

@kpet at the moment such a scenario is tested in CommandBufferGetCommandBufferInfo::RunStateInfoTest, I think we can close that issue.

shajder avatar Mar 20 '24 07:03 shajder

It looks like this was fixed by https://github.com/KhronosGroup/OpenCL-CTS/pull/1740 but the issue was never closed. Closing now.

kpet avatar Jul 16 '24 15:07 kpet