Ben Ashbaugh

Results 432 comments of Ben Ashbaugh

I'm starting to think the best option is to simply change the default for `BUILD_EXAMPLES` and `BUILD_DOCS` from enabled to disabled. I can't think of a clever way to set...

To simplify review, for now I've changed the order that the extensions are generated so they match the current order in the headers. Once we're convinced the code generation is...

Thanks everyone, I've added the discrepancies found so far to a task list in my original PR comment. I've also included https://github.com/KhronosGroup/OpenCL-Headers/issues/224, which I found previously.

> Guards `#if defined(_WIN32)` have been added around `cl_dx9_surface_info_khr` definition, it looks the right thing to do, just checking this is intended. I don't think this actually changed, though things...

> `clCreateProgramWithILKHR_fn` `CL_API_SUFFIX__VERSION_1_2` got removed, and was previously inconsistent with `clCreateProgramWithILKHR`. Because this was inconsistent previously I'm not exactly sure what to do with this one. For now, I'll add...

I found this one looking through old PRs. Is this something we should pursue? If not, I'll just close it. @MathiasMagnus

@MathiasMagnus heads up, I made one change to your suggested fix, since I think it had a copy-paste error. Otherwise, I think this one is ready to go.

@JablonskiMateusz, out of curiosity why does logging in locally "fix" this issue?

I'm going to go ahead and merge this even though there are CI failures because I think the failures are unrelated and already fixed in the main branch.

I haven't spent a lot of time looking at the OpenCL Torch code, so I may be mistaken, but I believe this is the issue: In xdot.c, the doDot() function...