astrale-sharp

Results 205 comments of astrale-sharp

For some reason wine is not in my PATH anymore which surely didn't help: EDIT: having it in my path again makes the code not go to the same path...

I mean, I don't have an issue anymore but isn't it a bit akward to have a undefined function there? :innocent:

We could check for the presence of the function and Raise an error hinting at wine being not present? I don't mind doing a quick PR either ;)

quick hack : `sudo chmod -x /usr/bin/wine* /opt/wine-stable/bin/wine*` Then ```bash ❯ python3 Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux Type "help", "copyright", "credits" or "license" for...

On second thought `Env::ensure()` seems to be called in turn calling `setup_wineprefix` Then we stumble upon this ```py # wenv/_core/env.py:394 proc = subprocess.Popen(["wine", "wineboot", "-i"], env=envvar_dict) proc.wait() if proc.returncode !=...

in `setup_wineprefix` we're actually returning before starting the process here and the process initialize wine if in overwrite mode.. maybe this would be a good place to check if wine...

`ensure` definitely feels like the place where function could return error code or just have an additional check and error reporting, although `setup_zugbruecke` seems like a good candidate too. I...

Also note that you cannot undo a remove connection yet, it should be easy to implement.

Also note that Documentation/Comments surrounding this PR could be improved The method generated by the macro return a Result, the impl to return this result is correct but stupid, I...

It could probably be ported to gdext (godot-rust) by now but it would likely need to be updated very regularly since gdext still has an unstable API, I personally don't...