Results 326 comments of Alejandro Colomar
trafficstars

I found the following: ``` ALX: nxt_conf_vldt_listener():1484 ALX: nxt_sockaddr_parse():544 ALX: nxt_sockaddr_parse_optport():566 ALX: nxt_sockaddr_unix_parse():635: 7 ALX: ALX: nxt_sockaddr_unix_parse():643: 6 ALX: ALX: nxt_sockaddr_text():293: 6 ALX: ALX: nxt_sockaddr_text():305: 6 ALX: ALX: nxt_sockaddr_parse_optport():585 ALX:...

A general inspection of the code looks good to me. In the conf validation, we parse the socket address to check it's a valid one, and discard the result. Later...

Tested: ``` $ ss -l | grep magic u_str LISTEN 0 511 @magic 32357 * 0 $ curl --abstract-unix-socket magic http://localhost/ idx ```

@echolimazulu This code should work for you, I guess. Now I'll try to make NGINX work with abstract sockets too.

> This is certainly the simplest and safest fix and if you wanted to have it stored in the config as _@name_ than that could be done separately as it's...

```json $ sudo curl --unix-socket /usr/local/control.unit.sock localhost/config { "listeners": { "unix:\u0000magic": { "pass": "routes", "client_ip": { "header": "X-Forwarded-For", "source": "unix" } } }, "routes": [ { "action": { "share": "/home/alx/srv/www/$uri"...

@lcrilly Tested: ``` alx@asus5775:~$ sudo curl --unix-socket /usr/local/control.unit.sock localhost/config { "listeners": { "unix:\u0000magic": { "pass": "routes", "client_ip": { "header": "X-Forwarded-For", "source": "unix" } } }, "routes": [ { "action": {...

In case we want to store a `@` in the state file (so that if a user queries unitd to read the current configuration, it will read the `@`), the...

Or, if we want to avoid dealing with `\0`s completely, we could use a different approach: stop transforming `@` into `\0` when parsing the socket name, and do it at...

I agree that I won't be touching the existing commits. I like them very much. Anything else would be added as a separate commit, and in a separate review process....