Results 326 comments of Alejandro Colomar
trafficstars

Ping. Hello, Are you interested in this feature? I'll close the PR, since the design was rejected. However, feel free to open a new one redesigned with the things talked...

I removed the implementation of `index` as an array. As suggested by @hongzhidao, I'm not sure we need it. I'll keep the code in a branch in my personal repository,...

For the first patch set (`index-str`; constant index string), I tested the following config, which works both with and without `--debug`: ```json { "listeners": { "*:80": { "pass": "routes/idx-html" },...

I already **merged** the following: ``` (ret404) Static: returning 404 when "index" is a non-regular file. (rename) Renamed nxt_http_static_ctx_t field 'index' to 'share_idx'. ```

Also merged: ``` (index-str) Tests: added tests for "index" (string) option. Static: supporting new "index" option. ```

We don't intend to add more of this feature for now. I'm closing this. If we ever want it, let's reopen it then.

> In fact, It's hard to fix these issues without refactoring. Maybe you can refactor without fixing the issues? So you could refactor as the first commit; and then fix...

If this PR is still necessary, please rebase it against the master branch.

Looks good to me. Please include something like `"If you don't call SSL_CTX_set_cipher_list, then you use system default."` in the commit message, and sign the patch (signed-off-by), and I'll merge...

BTW, it would also be nice if you add a changelog line into `docs/changes.xml`.