Results 326 comments of Alejandro Colomar
trafficstars

> Good news! > > Thanks for sharing this! > > Once again, I want to note that I do not insist on combining this PR, it seems to me...

> capabilities(7) might be a nice way of solving the unlink(2)ing of the socket files problem, on Linux at least. I don't know if they ever made it to other...

@artemkonev We should add a changelog for this, right? Supporting PHP 8.2

> > Did you have a link to the C API changelog just for documentation? > > Sorry nothing in UPGRADINGS (perhaps @Girgias may help, as he changes it in...

> > Okay, so please ping when you have an RC. I'll leave this open for now. > > You can merge the "code" fix without updating the "doc" claiming...

Looks good to me. I think we can already add the changelog now, since I wouldn't expect big breaking changes after the RC. Thank you!

> Heh, I think they can be squashed into a single commit... Actually I'd squash them into 2. The fixes for existing style I'd keep them separate. I can do...

> You mean squash the two brackets patches into one? I'd do a selective interactive rebase so that one of the brackets and part of the other are squasehd into...

Hi! I rebased to master, rewrote the commit logs, and signed on your behalf: ```git $ git log -2 commit 370e290c37fc2490fb4e02512a3ce3a8698ffe3b (HEAD -> php) Author: Remi Collet Date: Fri Oct...