Results 326 comments of Alejandro Colomar

I'm closing this. I'll push the updated patches to RB.

$runstatedir is where the control socket lives. It should be 755.

BTW, I didn't yet discern what this function does exactly. I know it creates the control socket, and I know it doesn't create the listeners, but is it used for...

> > $runstatedir is where the control socket lives. It should be 755. > > ```shell > $ ls -ld /tmp/unit/var/run/unit/ > drwxr-xr-x 2 andrew andrew 40 Aug 6 04:24...

> > BTW, I didn't yet discern what this function does exactly. I know it creates the control socket, and I know it doesn't create the listeners, but is it...

BTW, the pid file also lives in that directory. Does this fix that too? I don't know in which order unit tries to create the socket and the pid file.

> The following patch seems to do the trick, but it's late and I may have missed something... (may be missing some error checking...) > > ```diff > diff --git...

No, I think the code is fine as proposed in your patch. I just wanted to make sure that the obvious expected behavior was indeed occuring, which it is (per...

Fixed by [57fc920](https://github.com/nginx/unit/commit/57fc9201cb91e3d8901a64e3daaaf31684ee5bf5)

> I wonder if it even needs to be a file? Or could it just be stored internally to unit? That way users won't go thinking they can or should...