Anthony

Results 435 comments of Anthony
trafficstars

I don't have any solid guidance here yet. It might take some more exploring to figure out the best way to use the gutter and how we implement it to...

Oh sorry, yeah the space to the right. :+1:

I thought this would be fine, but I found in adding CI tests here that the sass-loader version doesn't like this. However, modern sass-loader is written for webpack 5, and...

CI is added and passing now, in https://github.com/readthedocs/ethical-ad-client/pull/149

We're still deciding if we want to support ad placements without stylesheets. There are definitely some good use cases for this. However, we also need to ensure a consistent base...

I don't believe we output any `` elements in our placements. Are you noticing otherwise, or is the case that you are surrounding the `` in a `` on your...

This feels like an option that we should be able to control at the ad server -- ie turn off community/house ads on the publisher, instead of requiring the user...

We shipped the first part of this work, but the other half of this issue still needs some discussion and planning. We can keep this issue around or break out...

For the initial pass here, we can add to the list of `Example configuration for` dropdown with basic examples -- anything that requires just our configurartion file. The next phase...

Ah I just reviewed your PR, I asked about this. I think it should be easy enough to trigger the tabs from the dropdown, and I'd like to retain the...