ethical-ad-client icon indicating copy to clipboard operation
ethical-ad-client copied to clipboard

Published 20 hours ago • verified publisher icon readthedocs

Dependencies: update node-sass

Open humitos opened this issue 2 years ago • 3 comments
trafficstars

This is just a test to try installing it via npm

npm install https://github.com/readthedocs/ethical-ad-client\#humitos/node-sass

humitos avatar Mar 13 '23 16:03 humitos

I thought this would be fine, but I found in adding CI tests here that the sass-loader version doesn't like this. However, modern sass-loader is written for webpack 5, and so there are two upgrades there that we'll need to make -- neither are huge, just more than I can tackle ATM.

I proposed a different option in #149 -- drop node-sass entirely for Dart sass, which is compiled to pure JS. No more node-gyp!

agjohnson avatar Mar 13 '23 17:03 agjohnson

I borrowed some ideas from https://github.com/readthedocs/ethical-ad-client/commit/b9e834dfa33c88658558f481576eced5f3980006#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

humitos avatar Mar 13 '23 17:03 humitos

CI is added and passing now, in https://github.com/readthedocs/ethical-ad-client/pull/149

agjohnson avatar Mar 13 '23 17:03 agjohnson