Anthony
Anthony
It sounds like there are two (related) projects here. I agree on the marketing focus here. I would say this feels like a good fit for website content -- showing...
While JSDoc is a indeed a standalone doctool, it's not actually common to see sites generated with JSDoc. It's used most commonly for lightweight type declaration and type checking more...
I had no clue how to answer that one myself, so just stuck with changing the API for now. I'd agree that's a better place to change it, but why...
If we have no clue why we did this, I am happy to make this change. However, if it cascades into fixing a lot of tests or we aren't 100%...
So yeah, a number of test failures here. But now some of the test failures (especially search unit tests) seem to imply the version list is backwards now:  https://app.circleci.com/pipelines/github/readthedocs/readthedocs.org/10217/workflows/902eefe5-cb97-4283-af40-31fd542317d0/jobs/25338?invite=true#step-107-370532_18...
@humitos @stsewd ping ^ I feel it's probably safe to only affect the API response for now. Something seems to be ordering versions (correctly) outside the API response (which is...
I ended up switching the version dropdown to not use our API, so this change also doesn't fix the ordering issue. https://github.com/readthedocs/ext-theme/issues/343 now just uses a queryset from a FilterSet...
So, though the API response is indeed backwards, this fix doesn't address the issue I noticed now. I will close this and we should fix this at the model level...
Pushing this to later, but we should consider fixing up build API v3 for our use high priority and get away from relying on API v2.
I'm not sure exactly how to prioritize this at the moment, I was hoping we'd be farther into APIv3 fixes for permissions probably. I'm going to move this to new...