Adam Bradley comments

Results 86 comments of


                                            Adam Bradley

trafficstars

fix: gtm scripts not working with loadScriptsOnMainThread by id

Sorry I must be misunderstanding then. How is this testing that setting `text` is working? Can help point out where the test would have failed before this update? Thanks

feat: add return value hook

Would the `get` hook instead be able to work in this scenario?

All qwik scripts are inserted after `</body>`, so it's invalid HTML

After some discussion we decided to close this issue and leave it as is since browsers are still executing the scripts correctly, despite being after the body.

Docs on how to integrate scripts into partytown. (Cookiebot)

Closing this issue since it has become stale, or has been addressed in recent releases and docs updates. If you feel this is still an issue please reopen a new...

Navigation broken after page reload

Closed with https://github.com/BuilderIO/qwik/pull/2263

Dynamic routing doesn't work when using trailing slashes

Thanks for opening the issue. This should be fixed in the latest release.

Fix: Let developers make their own error pages design

Thanks for opening the PR, but we had to fix this with a different approach to allow for a custom 404 to work and various directories. https://github.com/BuilderIO/qwik/pull/2175

The useLocation().query object values should return string or Array<string>

The `query` object is now a `URLSearchParams` as of https://github.com/BuilderIO/qwik/pull/2385 Thanks for opening the issue!

No File Endpoints are generated when `qwik build`

This should be fixed in the latest release. If it's still an issue please reopen with a repo case. Thanks!

Site is live but without any CSS styling Cloudflare Pages built

Should be fixed in the latest release, thanks for opening the issue.