Adam Bradley comments

Results 86 comments of


                                            Adam Bradley

trafficstars

Adds info about viewing the logs in Chrome DevTools

thanks

Better Regex to ignore $this variables in the code

Doesn't look like it's passing webkit. @jesse-deboer would you be able to see what the issue is? Thanks

Better Regex to ignore $this variables in the code

It looks like this error is only for webkit that every test fails, which is different from the other issue (i think).

Better Regex to ignore $this variables in the code

Sorry but this doesn't work on Safari. When I run it locally Safari will error with `SyntaxError: Invalid regular expression: invalid group specifier name`.

Partytown inconsistent behavior depending on how website is hosted

This may be because GTM is running scripts in different environment, not that partytown is. Would you be able to provide a repo case?

fix: exit early when both atomics and ServiceWorker are not supported

It doesn't appear the e2e tests are passing with this PR. Would you be able to further debug why the test isn't passing? Thanks

global function defined in one partytown script is not accessible to other partytown scripts

There currently is a config called `globalFn` and it's documented only in the types for now: https://github.com/BuilderIO/partytown/blob/072ac28bc17aedb6b97d01ee2c99013daa1064e7/src/lib/types.ts#L390-L398 Still trying to think of the best way to tackle this problem without...

fix(partytown): add style to image class

Thanks!

How to integrate partytown with angular?

Any assistance adding to angular integration docs would be appreciated. It could be a new page similar to https://github.com/BuilderIO/partytown/blob/main/docs/react.md

Zendesk integration

Any assistance recreating the issues Zendesk would have would be appreciated. You could replicate any issues by submitting a PR similar to the structure of another service, such as https://github.com/BuilderIO/partytown/tree/main/tests/integrations/gtm