qwik
qwik copied to clipboard
Fix: Let developers make their own error pages design
What is it?
- [x] Feature / enhancement
- [x] Bug
Description
Make simple changes to let developers make their own error pages and design as they want the developer should make designs for each error page if this PR merged and accepted, I'll update the rest of files and make more error pages to be ready for design
Checklist:
- [ ] My code follows the developer guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
- [ ] Added new tests to cover the fix / functionality
I really like this implementation, although it does shoehorn users into naming their pages with err-<errStatus>-page and limited options for the url of error routes.
Would it be possible to allow the user to define the dir of their choice for errors as well as the component name? maybe to set window.location.href to a ${errPageLocation} or even having an optional JSX Element prop which would return the actual component itself instead of navigating to a pre defied route?
Thanks for opening the PR, but we had to fix this with a different approach to allow for a custom 404 to work and various directories. https://github.com/BuilderIO/qwik/pull/2175