Alex Potsides

Results 539 comments of Alex Potsides

> In either case, when you encounter a protocol you don't understand the only thing you can do is store the unknown code and the rest of the multiaddr Yeah,...

I've fixed up the remaining modules. Thanks for your patience on this one, it'll definitely help new developers!

This looks good but it's full of conflicts now #1494 has been merged - could you rebase/merge master please?

Interesting. I would definitely switch to [datastore-level](https://www.npmjs.com/package/datastore-level) if that is an option.

A test should be added to the [datastore interface test suite](https://github.com/ipfs/js-stores/tree/main/packages/interface-datastore-tests) that exposes the bug along with a patch to fix it.

I've updated the PR that [re-enables coverage to only run coverage on node 20](https://github.com/ipfs/aegir/pull/1195) but it still hangs so I think that comment is a red herring. Edit: Actually looking...

Possibly related: https://github.com/nodejs/node/issues/49344