Alex Potsides

Results 537 comments of Alex Potsides

That's interesting, I think something like https://github.com/libp2p/js-libp2p/pull/2644 would help here, at least in that it'd clean up dead/stuck connections after a short time. We should be able to handle this...

I agree that this is a v2 thing, since we'll be removing a bunch of config. > then the ConnectionManager would also have to become a config that's passed in....

> all circuit relay connections will become transient This was true up until about a month ago when we merged https://github.com/libp2p/js-libp2p/pull/2575 - now relayed connections are only marked transient if...

> If I remember correctly, the identify protocol initiates a transient connection which is closed afterwards (?) Identify [runs on every newly opened connection](https://github.com/libp2p/js-libp2p/blob/main/packages/protocol-identify/src/identify.ts#L29-L32), it doesn't open or close connections...

> it seems like the parameterless constructor by default applies limits, so all circuit relay connections are now transient. Can you link to the code you are talking about? The...

> applyDefaultLimits will be true unless explicitly setting it to false Ah yes - this is by design. My mistake - I thought you meant the `Connection` constructor, not that...

https://github.com/libp2p/js-libp2p/pull/2541 has been merged, all WebKit transport-interop tests now pass apart from WebTransport so this should be good to go.

Promise.withResolvers is in node 22. What version are you using? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/withResolvers

No, sorry. I'm still waiting for @paullouisageneau to perform a release of libdatachannel with the memory leak fixes before spending more time here. https://github.com/murat-dogan/node-datachannel/issues/349#issuecomment-2857545150