Alex Potsides

It's up to date and the build is happy now so it's ready for review/merging. The linked PR seems unrelated.

I have removed the node upgrade, added the polyfill and run the formatter.

No, it should be an `ArrayBuffer` because that's the default value of `binaryType`. See - https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel/binaryType > When a binary message is received on the data channel, the resulting [message](https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel/message_event)...

Ah, you are right - I've updated the PR to retain string typing when strings are sent as before.

@murat-dogan thanks for merging this, any idea when it will make it into a release?

You need to upgrade the version of node you are running - `14.16.0` is too old.

It's a non standard option, true. It'll only appear as a valid option if you import the polyfill and use it directly. If you use the bundled types from `lib.dom.d.ts`...

The problem is that the `peerConnection` property of the polyfill is a private property so it cannot be accessed or overridden by a subclass. If you won't accept an init...

Will do! Though do you want to land #324 first as it'll likely cause conflicts. > I thought you didn't need this PR anymore No problem, I had gone a...

I tried adding a `createPeerConnection` method to the `RTCPeerConnection` polyfill class that subclasses can override. It doesn't really work though - since the `this.#peerConnection` field is set in the `RTCPeerConnection`...