Alex Potsides
Alex Potsides
That's a good question, I'm not sure. It runs on `ubuntu-latest` - is there some special config that's required? I can't see anything in the [build-linux.yml](https://github.com/murat-dogan/node-datachannel/blob/master/.github/workflows/build-linux.yml) file in this repo...
I've tried with `ubuntu-20.04` in [this run](https://github.com/libp2p/js-libp2p/actions/runs/5723105332/job/15508074728?pr=1918), it still fails with the same error. > And I can not see the full log? Is it normal? I'm not sure what...
Sorry for the delay in my replying - yes, the test suite runs on [nodejs](https://github.com/libp2p/js-libp2p/actions/runs/6107167751/job/16573778408?pr=1918) without error, the error only occurs on the [electron main process](https://github.com/libp2p/js-libp2p/actions/runs/6107167751/job/16573778796?pr=1918). I know electron bundles...
Progress! With the 0.5.0-dev release the tests now pass! Unfortunately it crashes after the test run with: ``` Command was killed with SIGABRT (Aborted): electron-mocha test/**/*.spec.{js,mjs,cjs} dist/test/**/*.spec.{js,cjs,mjs} --bail --timeout=60000 --colors...
No, unfortunately it still crashes after the test run. Here's a [recent test run](https://github.com/libp2p/js-libp2p/actions/runs/8172354233/job/22344699577?pr=1918). ``` @libp2p/webrtc: Command was killed with SIGABRT (Aborted): electron-mocha test/**/*.spec.{js,mjs,cjs} dist/test/**/*.spec.{js,cjs,mjs} --bail --timeout=60000 --colors --full-trace @libp2p/webrtc:...
Thanks for investigating. It's a monorepo project with cross-dependencies between the package siblings. From the output it looks like you've run `npm i` then `npx ...(test command)` in the repo...
> I couldn't find webrtc tests Ah, sorry - they are disabled right now because they fail in CI. I should have pasted the below. After installing and building in...
> Is it a solution for you? Yes! User error is the best kind of error 😅 . Thanks for looking in to this.
It's worth noting that calling the exported `cleanup` function after the test run makes the process exit successfully. From what I can see, [cleanup](https://github.com/murat-dogan/node-datachannel/blob/master/lib/index.js#L10) comes from [RTCWrapper](https://github.com/murat-dogan/node-datachannel/blob/master/src/rtc-wrapper.cpp#L16) which [closes](https://github.com/murat-dogan/node-datachannel/blob/master/src/rtc-wrapper.cpp#L116) all...
Calling `cleanup` isn't a solution for a server-style application that may service hundreds of thousands or millions of connections during it's lifetime. If I run this script with the `--trace-gc`...