Aaron Robertshaw

Results 175 comments of Aaron Robertshaw

Thanks for giving this a run @tellthemachines 👍 > Testing this now: registering styles via PHP is working as expected but I can't get it to work by adding a...

> I'd lean towards merging to start. Reasoning is you might have variations that just change certain characteristics but not others e.g. you want dark background of parent variation but...

I think this PR is getting closer to being ready to move out of draft status but there are a few aspects to it I'd like to flag and see...

Thanks for flagging that @tellthemachines, I'll need to revisit that aspect and dig through old notes to see what I was thinking or witnessing when implementing that part. Might be...

I've pushed a quick fix to remove the superfluous addition of the `style.variation` attribtue value. After a smoke test, it all still seems to be working ok. Thanks again for...

> do you mind rebasing and resolving? Rebasing this work onto trunk is already underway although I was balancing efforts there against other work and reviews etc. Should have this...

**Quick Update:** I started the process of rebasing this PR onto trunk but have run into lots of conflicts from varying sources. To be able to [discuss](https://github.com/WordPress/gutenberg/pull/60493#issuecomment-2041897559) some of the...

I've reworked a few aspects of this PR and rebased it onto trunk. After some smoke testing locally, I think it's ready for a closer look 🤞 Let me know...

Thank you, everyone, for all the great feedback, discussion, and testing so far! It's greatly appreciated 🙇 My apologies in advance for the incoming wall of text, but several recent...

> I noticed is that there seems to be something of with the default border radius Thanks for flagging that @fabiankaegy, I can replicate the issue 👍 Turns out I...