Aaron

Results 12 comments of Aaron
trafficstars

@illiteratewriter : Is this issue also present when reading `this.context` here? https://github.com/reactstrap/reactstrap/pull/2584/files#diff-9ee78bc9632271c79f00e1c79ae05005dd6ea11b1353a515e59fe5b8463efba0R341

Sorry, I meant to link to `Dropdown.js`, line 341: https://github.com/reactstrap/reactstrap/blob/master/src/Dropdown.js#L341 Just wondering if the `context` vs. `props` issue is present there as well.

It seems like the pattern throughout the library is to use the `innerRef` pattern instead. I'm not defending that pattern (I think this `forwardRef` / `ref` pattern is the best...

Fixed: https://github.com/reactstrap/reactstrap/pull/2642

I also see this behavior with `Menu` when `isNonModal` is set on the ``. I'm attempting to implement something close to https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/examples/disclosure-navigation/ The behavior where the Menu does not close...

Here's an example of the behavior with multiple `` components, all have a `` with `isNonModal` set. https://codesandbox.io/p/sandbox/cocky-http-y8wy43 Open a menu, click anywhere on the page (note the Popover doesn't...

Oh yeah. Wow. I completely mis-read the code there. Makes sense now! I'll get that fixed up.