reactstrap icon indicating copy to clipboard operation
reactstrap copied to clipboard

feat: add ref to modal

Open illiteratewriter opened this issue 2 years ago • 2 comments
trafficstars

#2089

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Chore
  • [ ] Breaking change
  • [x] There is an open issue which this change addresses
  • [x] I have read the CONTRIBUTING document.
  • [x] My commits follow the Git Commit Guidelines
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly.
  • [ ] My change requires a change to Typescript typings.
    • [ ] I have updated the typings accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

illiteratewriter avatar Mar 08 '23 12:03 illiteratewriter

It seems like the pattern throughout the library is to use the innerRef pattern instead. I'm not defending that pattern (I think this forwardRef / ref pattern is the best and recommended way to go). I'm just wondering if this is the right place to introduce a new way of handling refs? Perhaps a larger effort to switch patterns with a breaking change?

aaronmars avatar Sep 28 '23 17:09 aaronmars

This can be merged along with #2695 I guess.

illiteratewriter avatar Oct 06 '23 16:10 illiteratewriter