reactstrap
reactstrap copied to clipboard
feat: add ref to modal
trafficstars
#2089
- [ ] Bug fix
- [ ] New feature
- [ ] Chore
- [ ] Breaking change
- [x] There is an open issue which this change addresses
- [x] I have read the CONTRIBUTING document.
- [x] My commits follow the Git Commit Guidelines
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] My change requires a change to Typescript typings.
- [ ] I have updated the typings accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
It seems like the pattern throughout the library is to use the innerRef pattern instead. I'm not defending that pattern (I think this forwardRef / ref pattern is the best and recommended way to go). I'm just wondering if this is the right place to introduce a new way of handling refs? Perhaps a larger effort to switch patterns with a breaking change?
This can be merged along with #2695 I guess.